/* Tests in the "accounting" test case for the Expat test suite __ __ _ ___\ \/ /_ __ __ _| |_ / _ \\ /| '_ \ / _` | __| | __// \| |_) | (_| | |_ \___/_/\_\ .__/ \__,_|\__| |_| XML parser Copyright (c) 2001-2006 Fred L. Drake, Jr. Copyright (c) 2003 Greg Stein Copyright (c) 2005-2007 Steven Solie Copyright (c) 2005-2012 Karl Waclawek Copyright (c) 2016-2024 Sebastian Pipping Copyright (c) 2017-2022 Rhodri James Copyright (c) 2017 Joe Orton Copyright (c) 2017 José Gutiérrez de la Concha Copyright (c) 2018 Marco Maggi Copyright (c) 2019 David Loffredo Copyright (c) 2020 Tim Gates Copyright (c) 2021 Donghee Na Copyright (c) 2023 Sony Corporation / Snild Dolkow Licensed under the MIT license: Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions: The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software. THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE. */ #include /* NAN, INFINITY */ #include #include #include "expat_config.h" #include "expat.h" #include "internal.h" #include "common.h" #include "minicheck.h" #include "chardata.h" #include "handlers.h" #include "acc_tests.h" #if XML_GE == 1 START_TEST(test_accounting_precision) { struct AccountingTestCase cases[] = { {"", NULL, NULL, 0}, {"", NULL, NULL, 0}, /* Attributes */ {"", NULL, NULL, 0}, {"", NULL, NULL, 0}, {"", NULL, NULL, 0}, {"", NULL, NULL, sizeof(XML_Char) * 5 /* number of predefined entities */}, {"\n" " \n" "", NULL, NULL, 0}, /* Text */ {"text", NULL, NULL, 0}, {"text1text2", NULL, NULL, 0}, {"&'><"", NULL, NULL, sizeof(XML_Char) * 5 /* number of predefined entities */}, {"A)", NULL, NULL, 0}, /* Prolog */ {"", NULL, NULL, 0}, /* Whitespace */ {" ", NULL, NULL, 0}, {"", NULL, NULL, 0}, {"", NULL, NULL, 0}, /* Comments */ {"", NULL, NULL, 0}, /* Processing instructions */ {"", NULL, NULL, 0}, {"", NULL, NULL, 0}, # ifdef XML_DTD {"", "%e1;", "", 0}, # endif /* XML_DTD */ /* CDATA */ {"", NULL, NULL, 0}, /* The following is the essence of this OSS-Fuzz finding: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=34302 https://oss-fuzz.com/testcase-detail/4860575394955264 */ {"333\">\n" "]>\n" "&e;\n", NULL, NULL, sizeof(XML_Char) * strlen("111333")}, # ifdef XML_DTD /* Conditional sections */ {"\n" "\n" "\n" "%import;\n" "]>\n" "\n", "]]>\n" "]]>", NULL, sizeof(XML_Char) * (strlen("INCLUDE") + strlen("IGNORE"))}, # endif /* XML_DTD */ /* General entities */ {"\n" "]>\n" "&nine;", NULL, NULL, sizeof(XML_Char) * strlen("123456789")}, {"\n" "]>\n" "", NULL, NULL, sizeof(XML_Char) * strlen("123456789")}, {"\n" "\n" "]>\n" "&nine2;&nine2;&nine2;", NULL, NULL, sizeof(XML_Char) * 3 /* calls to &nine2; */ * 2 /* calls to &nine; */ * (strlen("&nine;") + strlen("123456789"))}, {"\n" "]>\n" "&five;", "12345", NULL, 0}, {"\n" "]>\n" "&five;", "\xEF\xBB\xBF" /* UTF-8 BOM */, NULL, 0}, # ifdef XML_DTD /* Parameter entities */ {"\">\n" "%comment;\n" "]>\n" "", NULL, NULL, sizeof(XML_Char) * strlen("")}, {"\n" "%ninedef;\n" "]>\n" "&nine;", NULL, NULL, sizeof(XML_Char) * (strlen("") + strlen("123456789"))}, {"\">\n" "%comment;\">\n" "%comment2;\n" "]>\n" "\n", NULL, NULL, sizeof(XML_Char) * (strlen("%comment;%comment;") + 2 * strlen(""))}, {"\n" " \n" " %five2def;\n" "]>\n" "&five2;", NULL, NULL, /* from "%five2def;": */ sizeof(XML_Char) * (strlen("") + 2 /* calls to "%five;" */ * strlen("12345") + /* from "&five2;": */ strlen("[12345][12345]]]]"))}, {"\n" "", "'>\n" "%comment;%comment;'>\n" "%comment2;", NULL, sizeof(XML_Char) * (strlen("%comment;%comment;") + 2 /* calls to "%comment;" */ * strlen(""))}, {"\n" "", "\n" "%e1;'>\n" "%e2;\n", "", sizeof(XML_Char) * strlen("")}, { "\n" "", "\n" "", "\n" "hello\n" "xml" /* without trailing newline! */, 0, }, { "\n" "", "\n" "", "\n" "hello\n" "xml\n" /* with trailing newline! */, 0, }, {"\n" "\n", "\n" "\n" "\n" "%e1;\n", "\xEF\xBB\xBF" /* UTF-8 BOM */, strlen("\xEF\xBB\xBF")}, # endif /* XML_DTD */ }; const size_t countCases = sizeof(cases) / sizeof(cases[0]); size_t u = 0; for (; u < countCases; u++) { const unsigned long long expectedCountBytesDirect = strlen(cases[u].primaryText); const unsigned long long expectedCountBytesIndirect = (cases[u].firstExternalText ? strlen(cases[u].firstExternalText) : 0) + (cases[u].secondExternalText ? strlen(cases[u].secondExternalText) : 0) + cases[u].expectedCountBytesIndirectExtra; XML_Parser parser = XML_ParserCreate(NULL); XML_SetParamEntityParsing(parser, XML_PARAM_ENTITY_PARSING_ALWAYS); if (cases[u].firstExternalText) { XML_SetExternalEntityRefHandler(parser, accounting_external_entity_ref_handler); XML_SetUserData(parser, (void *)&cases[u]); } enum XML_Status status = _XML_Parse_SINGLE_BYTES(parser, cases[u].primaryText, (int)strlen(cases[u].primaryText), XML_TRUE); if (status != XML_STATUS_OK) { _xml_failure(parser, __FILE__, __LINE__); } const unsigned long long actualCountBytesDirect = testingAccountingGetCountBytesDirect(parser); const unsigned long long actualCountBytesIndirect = testingAccountingGetCountBytesIndirect(parser); XML_ParserFree(parser); if (actualCountBytesDirect != expectedCountBytesDirect) { fprintf( stderr, "Document " EXPAT_FMT_SIZE_T("") " of " EXPAT_FMT_SIZE_T("") ": Expected " EXPAT_FMT_ULL( "") " count direct bytes, got " EXPAT_FMT_ULL("") " instead.\n", u + 1, countCases, expectedCountBytesDirect, actualCountBytesDirect); fail("Count of direct bytes is off"); } if (actualCountBytesIndirect != expectedCountBytesIndirect) { fprintf( stderr, "Document " EXPAT_FMT_SIZE_T("") " of " EXPAT_FMT_SIZE_T("") ": Expected " EXPAT_FMT_ULL( "") " count indirect bytes, got " EXPAT_FMT_ULL("") " instead.\n", u + 1, countCases, expectedCountBytesIndirect, actualCountBytesIndirect); fail("Count of indirect bytes is off"); } } } END_TEST START_TEST(test_billion_laughs_attack_protection_api) { XML_Parser parserWithoutParent = XML_ParserCreate(NULL); XML_Parser parserWithParent = XML_ExternalEntityParserCreate( parserWithoutParent, XCS("entity123"), NULL); if (parserWithoutParent == NULL) fail("parserWithoutParent is NULL"); if (parserWithParent == NULL) fail("parserWithParent is NULL"); // XML_SetBillionLaughsAttackProtectionMaximumAmplification, error cases if (XML_SetBillionLaughsAttackProtectionMaximumAmplification(NULL, 123.0f) == XML_TRUE) fail("Call with NULL parser is NOT supposed to succeed"); if (XML_SetBillionLaughsAttackProtectionMaximumAmplification(parserWithParent, 123.0f) == XML_TRUE) fail("Call with non-root parser is NOT supposed to succeed"); if (XML_SetBillionLaughsAttackProtectionMaximumAmplification( parserWithoutParent, NAN) == XML_TRUE) fail("Call with NaN limit is NOT supposed to succeed"); if (XML_SetBillionLaughsAttackProtectionMaximumAmplification( parserWithoutParent, -1.0f) == XML_TRUE) fail("Call with negative limit is NOT supposed to succeed"); if (XML_SetBillionLaughsAttackProtectionMaximumAmplification( parserWithoutParent, 0.9f) == XML_TRUE) fail("Call with positive limit <1.0 is NOT supposed to succeed"); // XML_SetBillionLaughsAttackProtectionMaximumAmplification, success cases if (XML_SetBillionLaughsAttackProtectionMaximumAmplification( parserWithoutParent, 1.0f) == XML_FALSE) fail("Call with positive limit >=1.0 is supposed to succeed"); if (XML_SetBillionLaughsAttackProtectionMaximumAmplification( parserWithoutParent, 123456.789f) == XML_FALSE) fail("Call with positive limit >=1.0 is supposed to succeed"); if (XML_SetBillionLaughsAttackProtectionMaximumAmplification( parserWithoutParent, INFINITY) == XML_FALSE) fail("Call with positive limit >=1.0 is supposed to succeed"); // XML_SetBillionLaughsAttackProtectionActivationThreshold, error cases if (XML_SetBillionLaughsAttackProtectionActivationThreshold(NULL, 123) == XML_TRUE) fail("Call with NULL parser is NOT supposed to succeed"); if (XML_SetBillionLaughsAttackProtectionActivationThreshold(parserWithParent, 123) == XML_TRUE) fail("Call with non-root parser is NOT supposed to succeed"); // XML_SetBillionLaughsAttackProtectionActivationThreshold, success cases if (XML_SetBillionLaughsAttackProtectionActivationThreshold( parserWithoutParent, 123) == XML_FALSE) fail("Call with non-NULL parentless parser is supposed to succeed"); XML_ParserFree(parserWithParent); XML_ParserFree(parserWithoutParent); } END_TEST START_TEST(test_helper_unsigned_char_to_printable) { // Smoke test unsigned char uc = 0; for (; uc < (unsigned char)-1; uc++) { set_subtest("char %u", (unsigned)uc); const char *const printable = unsignedCharToPrintable(uc); if (printable == NULL) fail("unsignedCharToPrintable returned NULL"); else if (strlen(printable) < (size_t)1) fail("unsignedCharToPrintable returned empty string"); } // Two concrete samples set_subtest("char 'A'"); if (strcmp(unsignedCharToPrintable('A'), "A") != 0) fail("unsignedCharToPrintable result mistaken"); set_subtest("char '\\'"); if (strcmp(unsignedCharToPrintable('\\'), "\\\\") != 0) fail("unsignedCharToPrintable result mistaken"); } END_TEST START_TEST(test_amplification_isolated_external_parser) { // NOTE: Length 44 is precisely twice the length of "" // (22) that is used in function accountingGetCurrentAmplification in // xmlparse.c. // 1.........1.........1.........1.........1..4 => 44 const char doc[] = ""; const int docLen = (int)sizeof(doc) - 1; const float maximumToleratedAmplification = 2.0f; struct TestCase { int offsetOfThreshold; enum XML_Status expectedStatus; }; struct TestCase cases[] = { {-2, XML_STATUS_ERROR}, {-1, XML_STATUS_ERROR}, {0, XML_STATUS_ERROR}, {+1, XML_STATUS_OK}, {+2, XML_STATUS_OK}, }; for (size_t i = 0; i < sizeof(cases) / sizeof(cases[0]); i++) { const int offsetOfThreshold = cases[i].offsetOfThreshold; const enum XML_Status expectedStatus = cases[i].expectedStatus; const unsigned long long activationThresholdBytes = docLen + offsetOfThreshold; set_subtest("offsetOfThreshold=%d, expectedStatus=%d", offsetOfThreshold, expectedStatus); XML_Parser parser = XML_ParserCreate(NULL); assert_true(parser != NULL); assert_true(XML_SetBillionLaughsAttackProtectionMaximumAmplification( parser, maximumToleratedAmplification) == XML_TRUE); assert_true(XML_SetBillionLaughsAttackProtectionActivationThreshold( parser, activationThresholdBytes) == XML_TRUE); XML_Parser ext_parser = XML_ExternalEntityParserCreate(parser, NULL, NULL); assert_true(ext_parser != NULL); const enum XML_Status actualStatus = _XML_Parse_SINGLE_BYTES(ext_parser, doc, docLen, XML_TRUE); assert_true(actualStatus == expectedStatus); if (actualStatus != XML_STATUS_OK) { assert_true(XML_GetErrorCode(ext_parser) == XML_ERROR_AMPLIFICATION_LIMIT_BREACH); } XML_ParserFree(ext_parser); XML_ParserFree(parser); } } END_TEST #endif // XML_GE == 1 void make_accounting_test_case(Suite *s) { #if XML_GE == 1 TCase *tc_accounting = tcase_create("accounting tests"); suite_add_tcase(s, tc_accounting); tcase_add_test(tc_accounting, test_accounting_precision); tcase_add_test(tc_accounting, test_billion_laughs_attack_protection_api); tcase_add_test(tc_accounting, test_helper_unsigned_char_to_printable); tcase_add_test__ifdef_xml_dtd(tc_accounting, test_amplification_isolated_external_parser); #else UNUSED_P(s); #endif /* XML_GE == 1 */ }